lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 29/32] platform/x86: GPD pocket fan: Fix error message when temp-limits are out of range
    Date
    From: Hans de Goede <hdegoede@redhat.com>

    commit 1d6f8c5bac93cceb2d4ac8e6331050652004d802 upstream.

    Commit 1f27dbd8265d ("platform/x86: GPD pocket fan: Allow somewhat
    lower/higher temperature limits") changed the module-param sanity check
    to accept temperature limits between 20 and 90 degrees celcius.

    But the error message printed when the module params are outside this
    range was not updated. This commit updates the error message to match
    the new min and max value for the temp-limits.

    Reported-by: Pavel Machek <pavel@denx.de>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Acked-by: Pavel Machek <pavel@denx.de>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/platform/x86/gpd-pocket-fan.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/platform/x86/gpd-pocket-fan.c
    +++ b/drivers/platform/x86/gpd-pocket-fan.c
    @@ -128,7 +128,7 @@ static int gpd_pocket_fan_probe(struct p

    for (i = 0; i < ARRAY_SIZE(temp_limits); i++) {
    if (temp_limits[i] < 20000 || temp_limits[i] > 90000) {
    - dev_err(&pdev->dev, "Invalid temp-limit %d (must be between 40000 and 70000)\n",
    + dev_err(&pdev->dev, "Invalid temp-limit %d (must be between 20000 and 90000)\n",
    temp_limits[i]);
    temp_limits[0] = TEMP_LIMIT0_DEFAULT;
    temp_limits[1] = TEMP_LIMIT1_DEFAULT;

    \
     
     \ /
      Last update: 2020-05-08 15:01    [W:4.772 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site