lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 237/312] mlx4: do not call napi_schedule() without care
    Date
    From: Eric Dumazet <edumazet@google.com>

    commit 8cf699ec849f4ca1413cea01289bd7d37dbcc626 upstream.

    Disable BH around the call to napi_schedule() to avoid following warning

    [ 52.095499] NOHZ: local_softirq_pending 08
    [ 52.421291] NOHZ: local_softirq_pending 08
    [ 52.608313] NOHZ: local_softirq_pending 08

    Fixes: 8d59de8f7bb3 ("net/mlx4_en: Process all completions in RX rings after port goes up")
    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Cc: Erez Shitrit <erezsh@mellanox.com>
    Cc: Eugenia Emantayev <eugenia@mellanox.com>
    Cc: Tariq Toukan <tariqt@mellanox.com>
    Acked-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
    +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
    @@ -1724,8 +1724,11 @@ int mlx4_en_start_port(struct net_device
    /* Process all completions if exist to prevent
    * the queues freezing if they are full
    */
    - for (i = 0; i < priv->rx_ring_num; i++)
    + for (i = 0; i < priv->rx_ring_num; i++) {
    + local_bh_disable();
    napi_schedule(&priv->rx_cq[i]->napi);
    + local_bh_enable();
    + }

    netif_tx_start_all_queues(dev);
    netif_device_attach(dev);

    \
     
     \ /
      Last update: 2020-05-08 14:48    [W:4.112 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site