lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 253/312] ovs/gre: fix rtnl notifications on iface deletion
    Date
    From: Nicolas Dichtel <nicolas.dichtel@6wind.com>

    commit da6f1da819d4b9c081a477dec74dc468a0b44290 upstream.

    The function gretap_fb_dev_create() (only used by ovs) never calls
    rtnl_configure_link(). The consequence is that dev->rtnl_link_state is
    never set to RTNL_LINK_INITIALIZED.
    During the deletion phase, the function rollback_registered_many() sends
    a RTM_DELLINK only if dev->rtnl_link_state is set to RTNL_LINK_INITIALIZED.

    Fixes: b2acd1dc3949 ("openvswitch: Use regular GRE net_device instead of vport")
    CC: Thomas Graf <tgraf@suug.ch>
    CC: Pravin B Shelar <pshelar@nicira.com>
    Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/ipv4/ip_gre.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/net/ipv4/ip_gre.c
    +++ b/net/ipv4/ip_gre.c
    @@ -1265,6 +1265,10 @@ struct net_device *gretap_fb_dev_create(
    if (err)
    goto out;

    + err = rtnl_configure_link(dev, NULL);
    + if (err < 0)
    + goto out;
    +
    return dev;
    out:
    ip_tunnel_dellink(dev, &list_kill);

    \
     
     \ /
      Last update: 2020-05-08 14:47    [W:6.473 / U:1.768 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site