lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 240/312] bonding: fix length of actor system
    Date
    From: Tobias Jungel <tobias.jungel@gmail.com>

    commit 414dd6fb9a1a1b59983aea7bf0f79f0085ecc5b8 upstream.

    The attribute IFLA_BOND_AD_ACTOR_SYSTEM is sent to user space having the
    length of sizeof(bond->params.ad_actor_system) which is 8 byte. This
    patch aligns the length to ETH_ALEN to have the same MAC address exposed
    as using sysfs.

    Fixes: f87fda00b6ed2 ("bonding: prevent out of bound accesses")
    Signed-off-by: Tobias Jungel <tobias.jungel@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/bonding/bond_netlink.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/net/bonding/bond_netlink.c
    +++ b/drivers/net/bonding/bond_netlink.c
    @@ -628,8 +628,7 @@ static int bond_fill_info(struct sk_buff
    goto nla_put_failure;

    if (nla_put(skb, IFLA_BOND_AD_ACTOR_SYSTEM,
    - sizeof(bond->params.ad_actor_system),
    - &bond->params.ad_actor_system))
    + ETH_ALEN, &bond->params.ad_actor_system))
    goto nla_put_failure;
    }
    if (!bond_3ad_get_active_agg_info(bond, &info)) {

    \
     
     \ /
      Last update: 2020-05-08 14:47    [W:4.213 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site