lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 174/312] VFIO: platform: reset: fix a warning message condition
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 967628827f404b3063016c138ccc7b06c54350f8 upstream.

    This loop ends with count set to -1 and not zero so the warning message
    isn't printed when it should be. I've fixed this by change the postop
    to a preop.

    Fixes: 0990822c9866 ('VFIO: platform: reset: AMD xgbe reset module')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Eric Auger <eric.auger@linaro.org>
    Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/vfio/platform/reset/vfio_platform_amdxgbe.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
    +++ b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
    @@ -110,7 +110,7 @@ int vfio_platform_amdxgbe_reset(struct v
    usleep_range(10, 15);

    count = 2000;
    - while (count-- && (ioread32(xgmac_regs->ioaddr + DMA_MR) & 1))
    + while (--count && (ioread32(xgmac_regs->ioaddr + DMA_MR) & 1))
    usleep_range(500, 600);

    if (!count)

    \
     
     \ /
      Last update: 2020-05-08 14:44    [W:2.586 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site