lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 155/312] of_mdio: fix node leak in of_phy_register_fixed_link error path
    Date
    From: Johan Hovold <johan@kernel.org>

    commit 48c1699d5335bc045b50989a06b1c526b17a25ff upstream.

    Make sure to drop the of_node reference also on failure to parse the
    speed property in of_phy_register_fixed_link().

    Fixes: 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/of/of_mdio.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/of/of_mdio.c
    +++ b/drivers/of/of_mdio.c
    @@ -334,8 +334,11 @@ int of_phy_register_fixed_link(struct de
    status.link = 1;
    status.duplex = of_property_read_bool(fixed_link_node,
    "full-duplex");
    - if (of_property_read_u32(fixed_link_node, "speed", &status.speed))
    + if (of_property_read_u32(fixed_link_node, "speed",
    + &status.speed)) {
    + of_node_put(fixed_link_node);
    return -EINVAL;
    + }
    status.pause = of_property_read_bool(fixed_link_node, "pause");
    status.asym_pause = of_property_read_bool(fixed_link_node,
    "asym-pause");

    \
     
     \ /
      Last update: 2020-05-08 14:43    [W:4.052 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site