Messages in this thread | | | Date | Fri, 8 May 2020 12:40:08 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH] powerpc/spufs: adjust list element pointer type |
| |
On Fri, 8 May 2020, Jeremy Kerr wrote:
> Hi Julia, > > > Other uses of &gang->aff_list_head, eg in spufs_assert_affinity, indicate > > that the list elements have type spu_context, not spu as used here. Change > > the type of tmp accordingly. > > Looks good to me; we could even use ctx there, rather than the separate > tmp variable.
I thought about that, but it seemed a little bit abusive, since ctx is used in an iteration over another list. But if you prefer that I can change it.
julia
> > Reviewed-by: Jeremy Kerr <jk@ozlabs.org> > > Cheers, > > > Jeremy > >
| |