lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RESENT PATCH RFC v3 4/5] scsi: ufs: add unit and geometry parameters for HPB
From
Date
On Thu, 2020-05-07 at 18:04 -0700, Bart Van Assche wrote:
> > + GEOMETRY_DESC_PARAM_HPB_REGION_SIZE = 0x48,
> > + GEOMETRY_DESC_PARAM_HPB_NUMBER_LU = 0x49,
> > + GEOMETRY_DESC_PARAM_HPB_SUBREGION_SIZE = 0x4A,
> > + GEOMETRY_DESC_PARAM_HPB_MAX_ACTIVE_REGIONS = 0x4B,
> > };
>
> How about adding the names from the spec as a comment above the new
> constants, e.g. as follows?
>
> /* wHPBPinnedRegionStartIdx */
> UNIT_DESC_PARAM_HPB_PIN_REGION_START_OFFSET = 0x25,
>
> Thanks,
>
> Bart.

Bart
I will add in the next version.

thanks,

Bean

\
 
 \ /
  Last update: 2020-05-08 12:17    [W:0.056 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site