lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] coresight: tmc: mark coresight_tmc_groups with static
Date
From: Chunyan Zhang <chunyan.zhang@unisoc.com>

Sparse reports a warning like:
drivers/hwtracing/coresight/coresight-tmc.c:364:30: warning: symbol
'coresight_tmc_groups' was not declared. Should it be static? [sparse]

coresight_tmc_groups is used in the local file only, so it should be
marked with static.

Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
---
drivers/hwtracing/coresight/coresight-tmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
index 1cf82fa..39fba1d 100644
--- a/drivers/hwtracing/coresight/coresight-tmc.c
+++ b/drivers/hwtracing/coresight/coresight-tmc.c
@@ -361,7 +361,7 @@ static ssize_t buffer_size_store(struct device *dev,
.name = "mgmt",
};

-const struct attribute_group *coresight_tmc_groups[] = {
+static const struct attribute_group *coresight_tmc_groups[] = {
&coresight_tmc_group,
&coresight_tmc_mgmt_group,
NULL,
--
1.9.1
\
 
 \ /
  Last update: 2020-05-08 11:15    [W:0.861 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site