lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 2/8] scsi: ufs: introduce fixup_dev_quirks vops
    Date
    Some UFS deivces may have required device quirks or have non-standard
    features which are enabled only on specified UFS hosts or for special
    customers.

    To not "pollute" common device quirk list, i.e., ufs_fixups table for
    those devices mentioned above, introduce "fixup_dev_quirks" vops to
    allow vendors to fix or modify device quirks accordingly.

    Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
    Reviewed-by: Avri Altman <avri.altman@wdc.com>
    ---
    drivers/scsi/ufs/ufshcd.c | 11 ++++++++++-
    drivers/scsi/ufs/ufshcd.h | 9 ++++++++-
    2 files changed, 18 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
    index a802c5f5ec7c..8d86d9a6a622 100644
    --- a/drivers/scsi/ufs/ufshcd.c
    +++ b/drivers/scsi/ufs/ufshcd.c
    @@ -6838,7 +6838,7 @@ static void ufshcd_wb_probe(struct ufs_hba *hba, u8 *desc_buf)
    hba->caps &= ~UFSHCD_CAP_WB_EN;
    }

    -static void ufs_fixup_device_setup(struct ufs_hba *hba)
    +static void ufshcd_fixup_dev_quirks(struct ufs_hba *hba)
    {
    struct ufs_dev_fix *f;
    struct ufs_dev_info *dev_info = &hba->dev_info;
    @@ -6853,6 +6853,15 @@ static void ufs_fixup_device_setup(struct ufs_hba *hba)
    }
    }

    +static void ufs_fixup_device_setup(struct ufs_hba *hba)
    +{
    + /* fix by general quirk table */
    + ufshcd_fixup_dev_quirks(hba);
    +
    + /* allow vendors to fix quirks */
    + ufshcd_vops_fixup_dev_quirks(hba);
    +}
    +
    static int ufs_get_device_desc(struct ufs_hba *hba)
    {
    int err;
    diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
    index 056537e52c19..897338ba67aa 100644
    --- a/drivers/scsi/ufs/ufshcd.h
    +++ b/drivers/scsi/ufs/ufshcd.h
    @@ -69,6 +69,7 @@
    #include <scsi/scsi_eh.h>

    #include "ufs.h"
    +#include "ufs_quirks.h"
    #include "ufshci.h"

    #define UFSHCD "ufshcd"
    @@ -336,6 +337,7 @@ struct ufs_hba_variant_ops {
    void (*hibern8_notify)(struct ufs_hba *, enum uic_cmd_dme,
    enum ufs_notify_change_status);
    int (*apply_dev_quirks)(struct ufs_hba *hba);
    + void (*fixup_dev_quirks)(struct ufs_hba *hba);
    int (*suspend)(struct ufs_hba *, enum ufs_pm_op);
    int (*resume)(struct ufs_hba *, enum ufs_pm_op);
    void (*dbg_register_dump)(struct ufs_hba *hba);
    @@ -950,7 +952,6 @@ int ufshcd_query_flag(struct ufs_hba *hba, enum query_opcode opcode,

    void ufshcd_auto_hibern8_enable(struct ufs_hba *hba);
    void ufshcd_auto_hibern8_update(struct ufs_hba *hba, u32 ahit);
    -
    #define SD_ASCII_STD true
    #define SD_RAW false
    int ufshcd_read_string_desc(struct ufs_hba *hba, u8 desc_index,
    @@ -1085,6 +1086,12 @@ static inline int ufshcd_vops_apply_dev_quirks(struct ufs_hba *hba)
    return 0;
    }

    +static inline void ufshcd_vops_fixup_dev_quirks(struct ufs_hba *hba)
    +{
    + if (hba->vops && hba->vops->fixup_dev_quirks)
    + hba->vops->fixup_dev_quirks(hba);
    +}
    +
    static inline int ufshcd_vops_suspend(struct ufs_hba *hba, enum ufs_pm_op op)
    {
    if (hba->vops && hba->vops->suspend)
    --
    2.18.0
    \
     
     \ /
      Last update: 2020-05-08 10:02    [W:3.319 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site