Messages in this thread | | | Date | Fri, 8 May 2020 00:30:13 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests |
| |
On Fri, May 08, 2020 at 04:53:55PM +1000, Michael Ellerman wrote: > It is Very Rude to clear dmesg in test scripts. That's because the > script may be part of a larger test run, and clearing dmesg > potentially destroys the output of other tests. > > We can avoid using dmesg -c by saving the content of dmesg before the > test, and then using diff to compare that to the dmesg afterward, > producing a log with just the added lines.
Sounds good to me!
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |