Messages in this thread | | | Subject | Re: [PATCH] net: tg3: tidy up loop, remove need to compute off with a multiply | From | Joe Perches <> | Date | Fri, 08 May 2020 19:31:48 -0700 |
| |
On Fri, 2020-05-08 at 18:48 -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 00:31:03 +0100 Colin Ian King wrote: > > > My preference would be for > > > > > > { > > > int i; > > > u32 off = 0; > > > > > > for (i = 0; i < TG3_SD_NUM_RECS; i++) { > > > tg3_ape_scratchpad_read(tp, (u32 *)ocir, off, TC3_OCIR_LEN); > > > > > > if (ocir->signature != TG3_OCIR_SIG_MAGIC || > > > !(ocir->version_flags & TG3_OCIR_FLAG_ACTIVE)) > > > memset(ocir, 0, TG3_OCIR_LEN); > > > > > > off += TG3_OCIR_LEN; > > > ocir++; > > > } > > > > > OK, I'll send a V3 tomorrow. > > I already reviewed and applied v2, just waiting for builds to finish, > let's leave it.
I think clarity should be preferred. Are you a maintainer of this file?
$ ./scripts/get_maintainer.pl -f drivers/net/ethernet/broadcom/tg3.c Siva Reddy Kallam <siva.kallam@broadcom.com> (supporter:BROADCOM TG3 GIGABIT ETHERNET DRIVER) Prashant Sreedharan <prashant@broadcom.com> (supporter:BROADCOM TG3 GIGABIT ETHERNET DRIVER) Michael Chan <mchan@broadcom.com> (supporter:BROADCOM TG3 GIGABIT ETHERNET DRIVER) "David S. Miller" <davem@davemloft.net> (odd fixer:NETWORKING DRIVERS) netdev@vger.kernel.org (open list:BROADCOM TG3 GIGABIT ETHERNET DRIVER) linux-kernel@vger.kernel.org (open list)
| |