lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net v1] hinic: fix a bug of ndo_stop
On Thu, 7 May 2020 18:22:27 +0000 Luo bin wrote:
> if some function in ndo_stop interface returns failure because of
> hardware fault, must go on excuting rest steps rather than return
> failure directly, otherwise will cause memory leak
>
> Signed-off-by: Luo bin <luobin9@huawei.com>

The code looks good, but would it make sense to split this patch into
two? First one that ignores the return values on close path with these
fixes tags:

Fixes: e2585ea77538 ("net-next/hinic: Add Rx handler")
Fixes: c4d06d2d208a ("net-next/hinic: Add Rx mode and link event handler")

And a separate patch which bumps the timeout for SET_FUNC_STATE? Right
now you don't even mention the timeout changes in the commit message.

\
 
 \ /
  Last update: 2020-05-08 23:24    [W:0.097 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site