Messages in this thread Patch in this message | | | From | Christoph Hellwig <> | Subject | [PATCH 03/12] pidfd: use __anon_inode_getfd | Date | Fri, 8 May 2020 17:36:25 +0200 |
| |
Use __anon_inode_getfd instead of opencoding the logic using get_unused_fd_flags + anon_inode_getfile.
Signed-off-by: Christoph Hellwig <hch@lst.de> --- kernel/fork.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c index 4385f3d639f23..31e0face01072 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -2113,19 +2113,11 @@ static __latent_entropy struct task_struct *copy_process( * if the fd table isn't shared). */ if (clone_flags & CLONE_PIDFD) { - retval = get_unused_fd_flags(O_RDWR | O_CLOEXEC); + retval = __anon_inode_getfd("[pidfd]", &pidfd_fops, pid, + O_RDWR | O_CLOEXEC, &pidfile); if (retval < 0) goto bad_fork_free_pid; - pidfd = retval; - - pidfile = anon_inode_getfile("[pidfd]", &pidfd_fops, pid, - O_RDWR | O_CLOEXEC); - if (IS_ERR(pidfile)) { - put_unused_fd(pidfd); - retval = PTR_ERR(pidfile); - goto bad_fork_free_pid; - } get_pid(pid); /* held by pidfile now */ retval = put_user(pidfd, args->pidfd); -- 2.26.2
| |