Messages in this thread | | | Date | Fri, 8 May 2020 09:49:45 -0400 | From | Steven Rostedt <> | Subject | Re: [RFC] taint: add module firmware crash taint support |
| |
On Fri, 8 May 2020 13:16:04 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > +++ b/include/trace/events/module.h > > @@ -26,7 +26,8 @@ struct module; > > { (1UL << TAINT_OOT_MODULE), "O" }, \ > > { (1UL << TAINT_FORCED_MODULE), "F" }, \ > > { (1UL << TAINT_CRAP), "C" }, \ > > - { (1UL << TAINT_UNSIGNED_MODULE), "E" }) > > + { (1UL << TAINT_UNSIGNED_MODULE), "E" }, \ > > + { (1UL << TAINT_FIRMWARE_CRASH), "Q" }) > > Perhaps split out the closing parenthesis to avoid changing additional line in > the future?
I don't think that will make a difference, as the last line must not contain a comma. New updates will still add additional line changes just to insert a comma before adding a new flag.
-- Steve
> > > TRACE_EVENT(module_load,
| |