lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] tools/bootconfig: fix resource leak in apply_xbc()
From
Date
> An error is found by a internel analysis tool:
> "Memory leak: data" and "Resource leak: fd" in tools/bootconfig/main.c

If such an information will ever be integrated into a final commit message,
I would prefer a wording variant like the following.

Two issues were pointed out by an internal source code analysis tool:
* Line …:
Memory leak: data

* Line …:
Resource leak: fd


Each of these issues has got a different importance for this function implementation.


> Fix the @data and @fd allocations that are leaked in the error path of
> apply_xbc().

How do you think about to replace the @ characters by other delimiters
for the relevant identifiers?

Regards,
Markus

\
 
 \ /
  Last update: 2020-05-08 15:46    [W:0.059 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site