Messages in this thread | | | Date | Fri, 8 May 2020 14:21:29 +0100 | From | Quentin Perret <> | Subject | Re: [PATCH 13/14] sched: cpufreq: Use IS_ENABLED() for schedutil |
| |
On Friday 08 May 2020 at 11:00:53 (+0530), Pavan Kondeti wrote: > > -#if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL) > > +#if defined(CONFIG_ENERGY_MODEL) && IS_ENABLED(CONFIG_CPU_FREQ_GOV_SCHEDUTIL) > > /* Build perf. domains: */ > > for (i = 0; i < ndoms_new; i++) { > > for (j = 0; j < n && !sched_energy_update; j++) { > > Now that scheduler does not have any references to schedutil_gov and cpufreq > has want_eas flag, do we need this CONFIG_CPU_FREQ_GOV_SCHEDUTIL checks here?
Right, they're not absolutely required, but given that sugov is the only one to have 'want_eas' set I guess there is no need to compile that in without it, no?
Cheers, Quentin
| |