lkml.org 
[lkml]   [2020]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 265/312] et131x: Fix logical vs bitwise check in et131x_tx_timeout()
    Date
    From: Florian Fainelli <f.fainelli@gmail.com>

    commit de702da7a823ab0c4a1e53ed79a2695f0d453855 upstream.

    We should be using a logical check here instead of a bitwise operation
    to check if the device is closed already in et131x_tx_timeout().

    Reported-by: coverity (CID 146498)
    Fixes: 38df6492eb511 ("et131x: Add PCIe gigabit ethernet driver et131x to drivers/net")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/ethernet/agere/et131x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/agere/et131x.c
    +++ b/drivers/net/ethernet/agere/et131x.c
    @@ -3854,7 +3854,7 @@ static void et131x_tx_timeout(struct net
    unsigned long flags;

    /* If the device is closed, ignore the timeout */
    - if (~(adapter->flags & FMP_ADAPTER_INTERRUPT_IN_USE))
    + if (!(adapter->flags & FMP_ADAPTER_INTERRUPT_IN_USE))
    return;

    /* Any nonrecoverable hardware error?

    \
     
     \ /
      Last update: 2020-05-08 15:15    [W:4.034 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site