lkml.org 
[lkml]   [2020]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch V4 part 2 05/18] x86/entry: Move irq tracing on syscall entry to C-code
Date
Thomas Gleixner <tglx@linutronix.de> writes:
> Alexandre Chartre <alexandre.chartre@oracle.com> writes:
>> On 5/5/20 3:41 PM, Thomas Gleixner wrote:
>>> - /*
>>> - * User mode is traced as though IRQs are on, and the interrupt
>>> - * gate turned them off.
>>> - */
>>> - TRACE_IRQS_OFF
>>> -
>>> movq %rsp, %rdi
>>> call do_int80_syscall_32
>>> .Lsyscall_32_done:
>>>
>>
>> enter_from_user_mode() is also called with the CALL_enter_from_user_mode macro,
>> which is used in interrupt_entry() and identry. Don't you need to also remove
>> the TRACE_IRQS_OFF there now?
>
> Hrm. right. OTOH, it's just redundant and should be no harm, but let me have a
> look at that again.

Grr, no. It'll trigger the warnon when context tracking is enabled. /me
scratches head and goes to fix.

\
 
 \ /
  Last update: 2020-05-07 17:05    [W:0.077 / U:1.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site