Messages in this thread Patch in this message | | | Date | Thu, 7 May 2020 14:38:52 +0200 | From | Peter Zijlstra <> | Subject | Re: [tip: objtool/core] objtool: Make handle_insn_ops() unconditional |
| |
On Fri, May 01, 2020 at 06:22:21PM -0000, tip-bot2 for Peter Zijlstra wrote: > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > index 068897d..6591c2d 100644 > --- a/tools/objtool/check.c > +++ b/tools/objtool/check.c > @@ -2259,6 +2259,9 @@ static int validate_branch(struct objtool_file *file, struct symbol *func, > return 0; > } > > + if (handle_insn_ops(insn, &state)) > + return 1; > + > switch (insn->type) { > > case INSN_RETURN:
Fun question; when an instruction has both a hint and ops, who should win? I'm currently in that situation and I'd like the hint to win, but is that 'right' ?
| |