Messages in this thread | | | Subject | Re: [net PATCH v2] net: hsr: fix incorrect type usage for protocol variable | From | Murali Karicheri <> | Date | Thu, 7 May 2020 08:14:15 -0400 |
| |
Hi David,
On 5/6/20 5:31 PM, Murali Karicheri wrote: > Fix following sparse checker warning:- > > net/hsr/hsr_slave.c:38:18: warning: incorrect type in assignment (different base types) > net/hsr/hsr_slave.c:38:18: expected unsigned short [unsigned] [usertype] protocol > net/hsr/hsr_slave.c:38:18: got restricted __be16 [usertype] h_proto > net/hsr/hsr_slave.c:39:25: warning: restricted __be16 degrades to integer > net/hsr/hsr_slave.c:39:57: warning: restricted __be16 degrades to integer > > Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> > Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > --- > v2 : Added Acked-by from Vinicius Costa Gomes > net/hsr/hsr_slave.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/hsr/hsr_slave.c b/net/hsr/hsr_slave.c > index f4b9f7a3ce51..25b6ffba26cd 100644 > --- a/net/hsr/hsr_slave.c > +++ b/net/hsr/hsr_slave.c > @@ -18,7 +18,7 @@ static rx_handler_result_t hsr_handle_frame(struct sk_buff **pskb) > { > struct sk_buff *skb = *pskb; > struct hsr_port *port; > - u16 protocol; > + __be16 protocol; > > if (!skb_mac_header_was_set(skb)) { > WARN_ONCE(1, "%s: skb invalid", __func__); > I saw that you have applied the initial patch to net-next. Please ignore this.
-- Murali Karicheri Texas Instruments
| |