Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 7 May 2020 12:17:05 +0300 | Subject | Re: [PATCH] x86: bitops: fix build regression |
| |
On Thu, May 7, 2020 at 10:50 AM David Laight <David.Laight@aculab.com> wrote: > From: Brian Gerst > > Sent: 07 May 2020 07:18
> > I think a better fix would be to make CONST_MASK() return a u8 value > > rather than have to cast on every use. > > Or assign to a local variable - then it doesn't matter how > the value is actually calculated. So: > u8 mask = CONST_MASK(nr);
Another case with negation won't work like this I believe. So, I thin kthe patch we have is good enough, no need to seek for an evil.
-- With Best Regards, Andy Shevchenko
| |