Messages in this thread | | | Date | Thu, 7 May 2020 17:50:49 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH] selftests/ftrace: mark irqsoff_tracer.tc test as unresolved if the test module does not exist |
| |
On Tue, 5 May 2020 18:14:45 +0800 Po-Hsu Lin <po-hsu.lin@canonical.com> wrote:
> The UNRESOLVED state is much more apporiate than the UNSUPPORTED state > for the absence of the test module, as it matches "test was set up > incorrectly" situation in the README file. > > A possible scenario is that the function was enabled (supported by the > kernel) but the module was not installed properly, in this case we > cannot call this as UNSUPPORTED. > > This change also make it consistent with other module-related tests > in ftrace. > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> --- > .../testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc b/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc > index cbd1743..2b82c80e 100644 > --- a/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc > +++ b/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc > @@ -17,7 +17,14 @@ unsup() { #msg > exit_unsupported > } > > -modprobe $MOD || unsup "$MOD module not available" > +unres() { #msg > + reset_tracer > + rmmod $MOD || true > + echo $1 > + exit_unresolved > +} > + > +modprobe $MOD || unres "$MOD module not available" > rmmod $MOD > > grep -q "preemptoff" available_tracers || unsup "preemptoff tracer not enabled" > -- > 2.7.4
-- Masami Hiramatsu <mhiramat@kernel.org>
| |