Messages in this thread | | | Subject | Re: [PATCH -next] staging: kpc2000: fix error return code in kp2000_pcie_probe() | From | Wei Yongjun <> | Date | Wed, 6 May 2020 21:08:51 +0800 |
| |
On 2020/5/6 20:57, Dan Carpenter wrote: > On Wed, May 06, 2020 at 12:52:55PM +0000, Wei Yongjun wrote: >> Fix to return a negative error code from the error handling >> case instead of 0, as done elsewhere in this function. Also >> removed var 'rv' since we can use 'err' instead. >> >> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > > Also could you add a Fixes tag? This goes all the way back to the > original commit: > > Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers") >
Will fix both of your comments in next version, thanks.
Regards, Wei Yongjun
| |