lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] drm/exynos: remove no need devm kfree in probe [re-send, welcome any comments]
From
Date
Remove no need devm_kfree in probe.
The change is to make the code a bit more readable

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/exynos/exynos_drm_dpi.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
index 43fa0f26c052..e06f7d7a6695 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c
@@ -181,10 +181,8 @@ static int exynos_dpi_parse_dt(struct exynos_dpi *ctx)
return -ENOMEM;

ret = of_get_videomode(dn, vm, 0);
- if (ret < 0) {
- devm_kfree(dev, vm);
+ if (ret < 0)
return ret;
- }

ctx->vm = vm;

@@ -233,10 +231,8 @@ struct drm_encoder *exynos_dpi_probe(struct device *dev)
ctx->dev = dev;

ret = exynos_dpi_parse_dt(ctx);
- if (ret < 0) {
- devm_kfree(dev, ctx);
- return NULL;
- }
+ if (ret < 0)
+ return ERR_PTR(ret);

if (ctx->panel_node) {
ctx->panel = of_drm_find_panel(ctx->panel_node);
--
2.26.2

[re-send, welcome any comments]
Regards,
Bernard




\
 
 \ /
  Last update: 2020-05-06 14:50    [W:0.058 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site