lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] serial: lantiq: Add x86 in Kconfig dependencies for Lantiq serial driver
From
Date

On 6/5/2020 2:41 pm, Greg KH wrote:
> On Wed, May 06, 2020 at 12:49:57PM +0800, Tanwar, Rahul wrote:
>> On 5/5/2020 10:25 pm, Greg KH wrote:
>>> On Mon, May 04, 2020 at 04:03:52PM +0800, Rahul Tanwar wrote:
>>>> Lantiq serial driver/IP is reused for a x86 based SoC as well.
>>>> Update the Kconfig accordingly.
>>>>
>>>> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
>>>> ---
>>>> drivers/tty/serial/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>>>> index 0aea76cd67ff..4b0a7b98f8c7 100644
>>>> --- a/drivers/tty/serial/Kconfig
>>>> +++ b/drivers/tty/serial/Kconfig
>>>> @@ -1035,7 +1035,7 @@ config SERIAL_SIFIVE_CONSOLE
>>>>
>>>> config SERIAL_LANTIQ
>>>> bool "Lantiq serial driver"
>>>> - depends on LANTIQ
>>>> + depends on (LANTIQ || X86) || COMPILE_TEST
>>>> select SERIAL_CORE
>>>> select SERIAL_CORE_CONSOLE
>>>> select SERIAL_EARLYCON
>>>> --
>>>> 2.11.0
>>>>
>>> Any reason this can't also be a module?
>> Thanks a lot for accepting the patch. This driver is also used for
>> console during bootup so we always have it as built in.
> So no generic kernel images can ever be made for this driver? That's
> not good, what about systems that have this serial port but does not
> care about the console?
>
> That's just ensuring that it will not be built into any distro kernel
> images, I suggest fixing this up please.

I understand your concern. I will send out another incremental patch
series to fix it assuming that this Kconfig change is already merged
in tty tree. Thanks.

Regards,
Rahul

> thanks,
>
> greg k-h

\
 
 \ /
  Last update: 2020-05-06 09:00    [W:0.160 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site