lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] kcsan: Add test suite
On Wed, May 6, 2020 at 2:30 AM Marco Elver <elver@google.com> wrote:
>
> This adds KCSAN test focusing on behaviour of the integrated runtime.
> Tests various race scenarios, and verifies the reports generated to
> console. Makes use of KUnit for test organization, and the Torture
> framework for test thread control.
>
> Signed-off-by: Marco Elver <elver@google.com>

Thanks, this works much better on my setup: having an explicit error
for there not being enough CPUs is a lot better than hanging. It'd
still be nice to have these be "skipped" rather than "failed" at some
stage, but that's a nice-to-have for the future once we've implemented
such a thing in KUnit.

I'm still a little hesitant about non-deterministic tests in general —
even if they're only run when CONFIG_KCSAN is enabled, it's possible
that a future CI system could run under KCSAN and report false
breakages on unrelated patches. Given no such setup exists yet,
though, I think it's probably a problem for the future rather than a
blocker at the moment.

Regardless, I hit no unexpected issues in my testing, so,

Tested-by: David Gow <davidgow@google.com>

-- David

\
 
 \ /
  Last update: 2020-05-06 06:46    [W:0.051 / U:1.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site