Messages in this thread | | | Subject | Re: [f2fs-dev] [PATCH] f2fs: remove redundant check in f2fs_force_buffered_io | From | Chao Yu <> | Date | Wed, 6 May 2020 14:48:18 +0800 |
| |
On 2020/5/5 11:23, Jaegeuk Kim wrote: > On 05/05, Chao Yu wrote: >> On 2020-5-4 22:35, Jaegeuk Kim wrote: >>> From: Daeho Jeong <daehojeong@google.com> >>> >>> We already checked whether the file is compressed or not in >>> f2fs_post_read_required(). So removed f2fs_compressed_file() >>> in f2fs_force_buffered_io(). >> >> Agreed, since I have sent similar patch before: >> >> https://lkml.org/lkml/2020/3/24/1819 > > Heh, as I couldn't find yours, I was actually waiting for you to point out. :)
Well, all patches sent to f2fs mailing list have been archived in lore.kernel.org/linux-f2fs-devel. :)
https://lore.kernel.org/linux-f2fs-devel/20200229104906.12061-1-yuchao0@huawei.com/
> >> >> Just want to know what's the change of backport concern now. > > Old ICE support had to decouple f2fs_post_read_required() and > f2fs_forced_buffered_io(). Now, I decide to manage this as we
Copied.
> need to manage this for one kernel version only.
Okay, thanks for the explanation.
Thanks,
> > Thanks, > >> >> Thanks, >> >>> >>> Signed-off-by: Daeho Jeong <daehojeong@google.com> >>> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> >>> --- >>> fs/f2fs/f2fs.h | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >>> index 6b7b963641696..01a00fc808361 100644 >>> --- a/fs/f2fs/f2fs.h >>> +++ b/fs/f2fs/f2fs.h >>> @@ -4064,8 +4064,6 @@ static inline bool f2fs_force_buffered_io(struct inode *inode, >>> return true; >>> if (f2fs_is_multi_device(sbi)) >>> return true; >>> - if (f2fs_compressed_file(inode)) >>> - return true; >>> /* >>> * for blkzoned device, fallback direct IO to buffered IO, so >>> * all IOs can be serialized by log-structured write. >>> > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > . >
| |