lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC 16/43] kexec: PKRAM: prevent kexec clobbering preserved pages in some cases
    Date
    When loading a kernel for kexec, dynamically update the list of physical
    ranges that are not to be used for storing preserved pages with the ranges
    where kexec segments will be copied to on reboot. This ensures no pages
    preserved after the new kernel has been loaded will reside in these ranges
    on reboot.

    Not yet handled is the case where pages have been preserved before a
    kexec kernel is loaded. This will be covered by a later patch.

    Signed-off-by: Anthony Yznaga <anthony.yznaga@oracle.com>
    ---
    kernel/kexec.c | 9 +++++++++
    kernel/kexec_file.c | 10 ++++++++++
    2 files changed, 19 insertions(+)

    diff --git a/kernel/kexec.c b/kernel/kexec.c
    index f977786fe498..c44598fc42a1 100644
    --- a/kernel/kexec.c
    +++ b/kernel/kexec.c
    @@ -16,6 +16,7 @@
    #include <linux/syscalls.h>
    #include <linux/vmalloc.h>
    #include <linux/slab.h>
    +#include <linux/pkram.h>

    #include "kexec_internal.h"

    @@ -163,6 +164,14 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments,
    if (ret)
    goto out;

    + for (i = 0; i < nr_segments; i++) {
    + unsigned long mem = image->segment[i].mem;
    + size_t memsz = image->segment[i].memsz;
    +
    + if (memsz)
    + pkram_ban_region(PFN_DOWN(mem), PFN_UP(mem + memsz) - 1);
    + }
    +
    /* Install the new kernel and uninstall the old */
    image = xchg(dest_image, image);

    diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
    index faa74d5f6941..f57f72237859 100644
    --- a/kernel/kexec_file.c
    +++ b/kernel/kexec_file.c
    @@ -26,6 +26,8 @@
    #include <linux/kernel.h>
    #include <linux/syscalls.h>
    #include <linux/vmalloc.h>
    +#include <linux/pkram.h>
    +
    #include "kexec_internal.h"

    static int kexec_calculate_store_digests(struct kimage *image);
    @@ -445,6 +447,14 @@ SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd,
    if (ret)
    goto out;

    + for (i = 0; i < image->nr_segments; i++) {
    + unsigned long mem = image->segment[i].mem;
    + size_t memsz = image->segment[i].memsz;
    +
    + if (memsz)
    + pkram_ban_region(PFN_DOWN(mem), PFN_UP(mem + memsz) - 1);
    + }
    +
    /*
    * Free up any temporary buffers allocated which are not needed
    * after image has been loaded
    --
    2.13.3
    \
     
     \ /
      Last update: 2020-05-07 02:45    [W:2.198 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site