lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: MAINTAINERS: Wrong ordering in S390 PCI SUBSYSTEM
From
Date
On Wed, 2020-05-06 at 13:51 +0300, Andy Shevchenko wrote:
> On Wed, May 6, 2020 at 8:46 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > Hi Pierre,
> >
> > with your commit de267a7c71ba ("s390/pci: Documentation for zPCI"),
> > visible on next-20200505, ./scripts/checkpatch.pl -f MAINTAINERS
> > complains:
> >
> > WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order
> > #14723: FILE: MAINTAINERS:14723:
> > +F: drivers/pci/hotplug/s390_pci_hpc.c
> > +F: Documentation/s390/pci.rst
> >
> >
> > This is due to wrong ordering of the entries in your submission. If you
> > would like me to send you a patch fixing that, please just let me know.
> >
> > It is a recent addition to checkpatch.pl to report ordering problems in
> > MAINTAINERS, so you might have not seen that at submission time.
>
> Why not to send a patch?
> Same for the rest of similar mails from you.

Frequently an original patch, which has yet to hit Linus' tree,
can be updated before being upstreamed to avoid unnecessary
additional patches.

It's also good form so the author of the original patch can be
aware of possible defects in submission.


\
 
 \ /
  Last update: 2020-05-06 19:10    [W:0.607 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site