Messages in this thread | | | Date | Tue, 5 May 2020 17:12:56 +0200 | From | Wolfram Sang <> | Subject | Re: [RFC PATCH] i2c: at91: Fix pinmux after devm_gpiod_get() for bus recovery |
| |
On Wed, Apr 15, 2020 at 10:06:43AM +0300, Codrin Ciubotariu wrote: > devm_gpiod_get() usually calls gpio_request_enable() for non-strict pinmux > drivers. These puts the pins in GPIO mode, whithout notifying the pinctrl > driver. At this point, the I2C bus no longer owns the pins. To mux the > pins back to the I2C bus, we use the pinctrl driver to change the state > of the pins to GPIO, before using devm_gpiod_get(). After the pins are > received as GPIOs, we switch theer pinctrl state back to the default > one, > > Fixes: d3d3fdcc4c90 ("i2c: at91: implement i2c bus recovery") > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Applied to for-current, thanks!
This will do for 5.7. For 5.8 or 5.9, I can imagine to take the two pinctrl_state pointers into bus_recovery_info and handle all this in the core. I will try this later this week if noone is super-eager to try it out before.
[unhandled content-type:application/pgp-signature] | |