Messages in this thread | | | Subject | Re: [PATCH v3] ipmi:bt-bmc: Fix error handling and status check | From | Tang Bin <> | Date | Tue, 5 May 2020 20:59:51 +0800 |
| |
Hi, Corey:
On 2020/5/5 19:49, Corey Minyard wrote: > On Tue, May 05, 2020 at 06:29:06PM +0800, Tang Bin wrote: >> If the function platform_get_irq() failed, the negative value >> returned will not be detected here. So fix error handling in >> bt_bmc_config_irq(). And in the function bt_bmc_probe(), >> when get irq failed, it will print error message. So use >> platform_get_irq_optional() to simplify code. Finally in the >> function bt_bmc_remove() should make the right status check >> if get irq failed. > Ok, this is included in my tree.
I just want to say: thank you very much.
After many days of communication with you, I have learned a lot, your patient teaching has inspired me a lot. It's my pleasure to meet you.
Thanks,
Tang Bin
>
| |