Messages in this thread | | | From | Peter Robinson <> | Date | Tue, 5 May 2020 13:35:14 +0100 | Subject | Re: [PATCH v2 2/2] usb: xhci: Load Raspberry Pi 4 VL805's firmware |
| |
> > On 30/04/2020 15:04, Nicolas Saenz Julienne wrote: > > When needed, RPi4's co-processor (called VideoCore) has to be instructed > > to load VL805's firmware (the chip providing xHCI support). VideoCore's > > firmware expects the board's PCIe bus to be already configured in order > > for it to load the xHCI chip firmware. So we have to make sure this > > happens in between the PCIe configuration and xHCI startup. > > > > Introduce a callback in xhci_pci_probe() to run this platform specific > > routine. > > > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > > > > --- > > > > Changes since v1: > > - Create callback > > > > board/raspberrypi/rpi/rpi.c | 12 ++++++++++++ > > drivers/usb/host/xhci-pci.c | 6 ++++++ > > include/usb/xhci.h | 3 +++ > > 3 files changed, 21 insertions(+) > > > > diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c > > index e367ba3092..8aa78d1f48 100644 > > --- a/board/raspberrypi/rpi/rpi.c > > +++ b/board/raspberrypi/rpi/rpi.c > > @@ -14,6 +14,7 @@ > > #include <lcd.h> > > #include <memalign.h> > > #include <mmc.h> > > +#include <usb/xhci.h> > > #include <asm/gpio.h> > > #include <asm/arch/mbox.h> > > #include <asm/arch/msg.h> > > @@ -494,3 +495,14 @@ int ft_board_setup(void *blob, bd_t *bd) > > > > return 0; > > } > > + > > +#ifdef CONFIG_BCM2711 > > This won't work with rpi_arm64_defconfig. > Can't we just evaluate at runtime if we need to do anything in xhci_pci_fixup. > > I wonder if the newer RPi4 have also a newer revision ID (see get_board_rev). If > so we could add another bool to struct rpi_model which will indicate us if we > need to notify VideoCore about vl805's firmware.
I believe they're ones ending in 03112: https://github.com/raspberrypi/documentation/tree/master/hardware/raspberrypi/revision-codes
| |