Messages in this thread | | | Subject | Re: [PATCH net-next 3/7] net: ethernet: ti: am65-cpsw-nuss: enable packet timestamping support | From | Grygorii Strashko <> | Date | Tue, 5 May 2020 14:05:11 +0300 |
| |
hi Anders,
On 05/05/2020 13:17, Anders Roxell wrote: > On Fri, 1 May 2020 at 22:50, Grygorii Strashko <grygorii.strashko@ti.com> wrote: >> >> The MCU CPSW Common Platform Time Sync (CPTS) provides possibility to >> timestamp TX PTP packets and all RX packets. >> >> This enables corresponding support in TI AM65x/J721E MCU CPSW driver. >> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> --- >> drivers/net/ethernet/ti/Kconfig | 1 + >> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 24 ++- >> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 172 ++++++++++++++++++++ >> drivers/net/ethernet/ti/am65-cpsw-nuss.h | 6 +- >> 4 files changed, 201 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig >> index 1f4e5b6dc686..2c7bd1ccaaec 100644 >> --- a/drivers/net/ethernet/ti/Kconfig >> +++ b/drivers/net/ethernet/ti/Kconfig >> @@ -100,6 +100,7 @@ config TI_K3_AM65_CPSW_NUSS >> depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER >> select TI_DAVINCI_MDIO >> imply PHY_TI_GMII_SEL >> + imply TI_AM65_CPTS > > Should this be TI_K3_AM65_CPTS ? > > I did an arm64 allmodconfig build on todays next tag: next-20200505 > and got this undefined symbol: > > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > function `am65_cpsw_init_cpts': > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1685: > undefined reference to `am65_cpts_create' > aarch64-linux-gnu-ld: > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1685:(.text+0x2e20): > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > `am65_cpts_create' > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > function `am65_cpsw_nuss_tx_compl_packets': > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:923: > undefined reference to `am65_cpts_tx_timestamp' > aarch64-linux-gnu-ld: > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:923:(.text+0x4cf0): > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > `am65_cpts_tx_timestamp' > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > function `am65_cpsw_nuss_ndo_slave_xmit': > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1018: > undefined reference to `am65_cpts_prep_tx_timestamp' > aarch64-linux-gnu-ld: > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1018:(.text+0x58fc): > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > `am65_cpts_prep_tx_timestamp' > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-nuss.o: in > function `am65_cpsw_nuss_hwtstamp_set': > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1265: > undefined reference to `am65_cpts_rx_enable' > aarch64-linux-gnu-ld: > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-nuss.c:1265:(.text+0x7564): > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > `am65_cpts_rx_enable' > aarch64-linux-gnu-ld: drivers/net/ethernet/ti/am65-cpsw-ethtool.o: in > function `am65_cpsw_get_ethtool_ts_info': > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-ethtool.c:713: > undefined reference to `am65_cpts_phc_index' > aarch64-linux-gnu-ld: > /srv/src/kernel/next/obj-arm64-next-20200505/../drivers/net/ethernet/ti/am65-cpsw-ethtool.c:713:(.text+0xbe8): > relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > `am65_cpts_phc_index' > make[1]: *** [/srv/src/kernel/next/Makefile:1114: vmlinux] Error 1 > make[1]: Target 'Image' not remade because of errors. > make: *** [Makefile:180: sub-make] Error 2 > make: Target 'Image' not remade because of errors.
Sry, I can't reproduce it net-next. trying next... What's your config?
-- Best regards, grygorii
| |