Messages in this thread | | | Date | Tue, 5 May 2020 12:48:05 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 1/5] binfmt_elf_fdpic: Stop using dump_emit() on user pointers on !MMU |
| |
On Wed, Apr 29, 2020 at 11:49:50PM +0200, Jann Horn wrote: > dump_emit() is for kernel pointers, and VMAs describe userspace memory. > Let's be tidy here and avoid accessing userspace pointers under KERNEL_DS, > even if it probably doesn't matter much on !MMU systems - especially given > that it looks like we can just use the same get_dump_page() as on MMU if > we move it out of the CONFIG_MMU block.
Looks sensible. Did you get a chance to test this with a nommu setup?
| |