lkml.org 
[lkml]   [2020]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: Re: [v3,iproute2 1/2] iproute2:tc:action: add a gate control action
Date
Hi Stephen,

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: 2020年5月5日 8:07
> To: Po Liu <po.liu@nxp.com>
> Cc: davem@davemloft.net; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; vinicius.gomes@intel.com; vlad@buslov.dev;
> Claudiu Manoil <claudiu.manoil@nxp.com>; Vladimir Oltean
> <vladimir.oltean@nxp.com>; Alexandru Marginean
> <alexandru.marginean@nxp.com>; michael.chan@broadcom.com;
> vishal@chelsio.com; saeedm@mellanox.com; leon@kernel.org;
> jiri@mellanox.com; idosch@mellanox.com;
> alexandre.belloni@bootlin.com; UNGLinuxDriver@microchip.com;
> kuba@kernel.org; xiyou.wangcong@gmail.com;
> simon.horman@netronome.com; pablo@netfilter.org;
> moshe@mellanox.com; m-karicheri2@ti.com;
> andre.guedes@linux.intel.com
> Subject: Re: [v3,iproute2 1/2] iproute2:tc:action: add a gate control
> action
>
> On Sun, 3 May 2020 14:32:50 +0800
> Po Liu <Po.Liu@nxp.com> wrote:
>
> > + print_string(PRINT_ANY, "gate state", "\tgate-state %-8s",
>
> NAK
> Space in a json tag is not valid.
>
> Please run a dump command and feed it into JSON validation checker like
> Python.

I would test json format and upload new version patch set.

Thanks!
Br,
Po Liu
\
 
 \ /
  Last update: 2020-05-05 11:29    [W:0.024 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site