Messages in this thread | | | From | Pavel Tatashin <> | Date | Tue, 5 May 2020 00:21:59 -0400 | Subject | Re: [PATCH v1 1/3] printk: honor the max_reason field in kmsg_dumper |
| |
> > I changed it to make code cleaner: for such basic operation there are > > too many conditions if we will keep it inside the kmsg_dump(). > > However, if being able to set always_kmsg_dump dynamically during > > runtime is deemed important, I can change it back to be checked in > > kmsg_dump. > > If you agree that we do not have to modify this variable dynamically, > I will also change the permission here: > module_param_named(always_kmsg_dump, always_kmsg_dump, bool, S_IRUGO | S_IWUSR);
Hi Sergey,
After thinking about this. I will move this logic back to kmsg_dump(), to keep the current behavior where kmsg_dump can be modified during runtime.
Thank you, Pasha
| |