lkml.org 
[lkml]   [2020]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: sun8i: Fix an error handling path in deinterlace_runtime_resume()
From
Date
> It is spurious to call 'clk_disable_unprepare()' when
> 'clk_prepare_enable()' has not been called yet.

Can it be that the usage of the word “suspicious” would be more appropriate
for such a change description?


> Re-order the error handling path to avoid it.

Would it be also helpful to explicitly mention in the commit message
that you would like to move a call of the function “clk_rate_exclusive_put”
to the end of this function implementation for the correction
of the desired exception handling?

Regards,
Markus

\
 
 \ /
  Last update: 2020-05-05 10:16    [W:0.240 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site