lkml.org 
[lkml]   [2020]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Bluetooth: Terminate the link if pairing is cancelled
Hi Manish, Marcel,

On Tue, Apr 28, 2020 at 2:38 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Manish,
>
> > If user decides to cancel ongoing pairing process (e.g. by clicking
> > the cancel button on the pairing/passkey window), abort any ongoing
> > pairing and then terminate the link.
> >
> > Signed-off-by: Manish Mandlik <mmandlik@google.com>
> > ---
> > Hello Linux-Bluetooth,
> >
> > This patch aborts any ongoing pairing and then terminates the link
> > by calling hci_abort_conn() in cancel_pair_device() function.
> >
> > However, I'm not very sure if hci_abort_conn() should be called here
> > in cancel_pair_device() or in smp for example to terminate the link
> > after it had sent the pairing failed PDU.
> >

Id recommend leaving the hci_abort_conn out since that is a policy
decision the userspace should be in charge to decide if the link
should be disconnected or not.

> > Please share your thoughts on this.
>
> I am look into this. Just bare with me for a bit to verify the call chain.
>
> Regards
>
> Marcel
>


--
Luiz Augusto von Dentz

\
 
 \ /
  Last update: 2020-05-06 02:00    [W:0.060 / U:0.968 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site