lkml.org 
[lkml]   [2020]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] RISC-V: Remove unused code from STRICT_KERNEL_RWX
From
On Sun, 03 May 2020 21:03:19 PDT (-0700), Atish Patra wrote:
> This patch removes the unused functions set_kernel_text_rw/ro.
> Currently, it is not being invoked from anywhere and no other architecture
> (except arm) uses this code. Even in ARM, these functions are not invoked
> from anywhere currently.
>
> Fixes: d27c3c90817e ("riscv: add STRICT_KERNEL_RWX support")
>
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> ---
> arch/riscv/mm/init.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index b55be44ff9bd..ba60a581e9b6 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -501,22 +501,6 @@ static inline void setup_vm_final(void)
> #endif /* CONFIG_MMU */
>
> #ifdef CONFIG_STRICT_KERNEL_RWX
> -void set_kernel_text_rw(void)
> -{
> - unsigned long text_start = (unsigned long)_text;
> - unsigned long text_end = (unsigned long)_etext;
> -
> - set_memory_rw(text_start, (text_end - text_start) >> PAGE_SHIFT);
> -}
> -
> -void set_kernel_text_ro(void)
> -{
> - unsigned long text_start = (unsigned long)_text;
> - unsigned long text_end = (unsigned long)_etext;
> -
> - set_memory_ro(text_start, (text_end - text_start) >> PAGE_SHIFT);
> -}
> -
> void mark_rodata_ro(void)
> {
> unsigned long text_start = (unsigned long)_text;

Thanks, this is on fixes. Are you going to remove the ARM code as well?

\
 
 \ /
  Last update: 2020-05-06 01:56    [W:0.080 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site