Messages in this thread | | | Date | Tue, 5 May 2020 13:46:56 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 2/7] exec: Make unlocking exec_update_mutex explict |
| |
On Tue, May 05, 2020 at 02:41:47PM -0500, Eric W. Biederman wrote: > > With install_exec_creds updated to follow immediately after > setup_new_exec, the failure of unshare_sighand is the only > code path where exec_update_mutex is held but not explicitly > unlocked. > > Update that code path to explicitly unlock exec_update_mutex. > > Remove the unlocking of exec_update_mutex from free_bprm. > > Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |