lkml.org 
[lkml]   [2020]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] mm: Add kvfree_sensitive() for freeing sensitive data objects
On Tue, 07 Apr 2020 21:21:57 +0100 David Howells <dhowells@redhat.com> wrote:

> David Howells <dhowells@redhat.com> wrote:
>
> > > if (unlikely(key_data))
> > > - __kvzfree(key_data, key_data_len);
> > > + kvfree_sensitive(key_data, key_data_len);
> >
> > I think the if-statement is redundant.
>
> Ah - I see that you explicitly wanted to keep it.

Why's that?

> There's a good chance it'll get janitored at some point.

Indeed. Perhaps add a few little comments to explain the reasoning and
to keep the janitorial fingers away?

\
 
 \ /
  Last update: 2020-05-05 22:36    [W:0.183 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site