Messages in this thread | | | Date | Tue, 5 May 2020 13:35:21 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v3] mm: Add kvfree_sensitive() for freeing sensitive data objects |
| |
On Tue, 07 Apr 2020 21:21:57 +0100 David Howells <dhowells@redhat.com> wrote:
> David Howells <dhowells@redhat.com> wrote: > > > > if (unlikely(key_data)) > > > - __kvzfree(key_data, key_data_len); > > > + kvfree_sensitive(key_data, key_data_len); > > > > I think the if-statement is redundant. > > Ah - I see that you explicitly wanted to keep it.
Why's that?
> There's a good chance it'll get janitored at some point.
Indeed. Perhaps add a few little comments to explain the reasoning and to keep the janitorial fingers away?
| |