lkml.org 
[lkml]   [2020]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 26/73] ALSA: line6: Fix POD HD500 audio playback
    Date
    From: Vasily Khoruzhick <anarsoul@gmail.com>

    commit cc18b2f4f3f1d7ed3125ac1840794f9feab0325c upstream.

    Apparently interface 1 is control interface akin to HD500X,
    setting LINE6_CAP_CONTROL and choosing it as ctrl_if fixes
    audio playback on POD HD500.

    Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20200425201115.3430-1-anarsoul@gmail.com
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/usb/line6/podhd.c | 22 +++++-----------------
    1 file changed, 5 insertions(+), 17 deletions(-)

    --- a/sound/usb/line6/podhd.c
    +++ b/sound/usb/line6/podhd.c
    @@ -21,8 +21,7 @@
    enum {
    LINE6_PODHD300,
    LINE6_PODHD400,
    - LINE6_PODHD500_0,
    - LINE6_PODHD500_1,
    + LINE6_PODHD500,
    LINE6_PODX3,
    LINE6_PODX3LIVE,
    LINE6_PODHD500X,
    @@ -318,8 +317,7 @@ static const struct usb_device_id podhd_
    /* TODO: no need to alloc data interfaces when only audio is used */
    { LINE6_DEVICE(0x5057), .driver_info = LINE6_PODHD300 },
    { LINE6_DEVICE(0x5058), .driver_info = LINE6_PODHD400 },
    - { LINE6_IF_NUM(0x414D, 0), .driver_info = LINE6_PODHD500_0 },
    - { LINE6_IF_NUM(0x414D, 1), .driver_info = LINE6_PODHD500_1 },
    + { LINE6_IF_NUM(0x414D, 0), .driver_info = LINE6_PODHD500 },
    { LINE6_IF_NUM(0x414A, 0), .driver_info = LINE6_PODX3 },
    { LINE6_IF_NUM(0x414B, 0), .driver_info = LINE6_PODX3LIVE },
    { LINE6_IF_NUM(0x4159, 0), .driver_info = LINE6_PODHD500X },
    @@ -352,23 +350,13 @@ static const struct line6_properties pod
    .ep_audio_r = 0x82,
    .ep_audio_w = 0x01,
    },
    - [LINE6_PODHD500_0] = {
    + [LINE6_PODHD500] = {
    .id = "PODHD500",
    .name = "POD HD500",
    - .capabilities = LINE6_CAP_PCM
    + .capabilities = LINE6_CAP_PCM | LINE6_CAP_CONTROL
    | LINE6_CAP_HWMON,
    .altsetting = 1,
    - .ep_ctrl_r = 0x81,
    - .ep_ctrl_w = 0x01,
    - .ep_audio_r = 0x86,
    - .ep_audio_w = 0x02,
    - },
    - [LINE6_PODHD500_1] = {
    - .id = "PODHD500",
    - .name = "POD HD500",
    - .capabilities = LINE6_CAP_PCM
    - | LINE6_CAP_HWMON,
    - .altsetting = 0,
    + .ctrl_if = 1,
    .ep_ctrl_r = 0x81,
    .ep_ctrl_w = 0x01,
    .ep_audio_r = 0x86,

    \
     
     \ /
      Last update: 2020-05-04 20:06    [W:4.088 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site