lkml.org 
[lkml]   [2020]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 21/57] ALSA: hda/hdmi: fix without unlocked before return
    Date
    From: Wu Bo <wubo40@huawei.com>

    commit a2f647240998aa49632fb09b01388fdf2b87acfc upstream.

    Fix the following coccicheck warning:
    sound/pci/hda/patch_hdmi.c:1852:2-8: preceding lock on line 1846

    After add sanity check to pass klockwork check,
    The spdif_mutex should be unlock before return true
    in check_non_pcm_per_cvt().

    Fixes: 960a581e22d9 ("ALSA: hda: fix some klockwork scan warnings")
    Signed-off-by: Wu Bo <wubo40@huawei.com>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/1587907042-694161-1-git-send-email-wubo40@huawei.com
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/hda/patch_hdmi.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/sound/pci/hda/patch_hdmi.c
    +++ b/sound/pci/hda/patch_hdmi.c
    @@ -1861,8 +1861,10 @@ static bool check_non_pcm_per_cvt(struct
    /* Add sanity check to pass klockwork check.
    * This should never happen.
    */
    - if (WARN_ON(spdif == NULL))
    + if (WARN_ON(spdif == NULL)) {
    + mutex_unlock(&codec->spdif_mutex);
    return true;
    + }
    non_pcm = !!(spdif->status & IEC958_AES0_NONAUDIO);
    mutex_unlock(&codec->spdif_mutex);
    return non_pcm;

    \
     
     \ /
      Last update: 2020-05-04 20:04    [W:3.088 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site