lkml.org 
[lkml]   [2020]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 17/26] RDMA/mlx4: Initialize ib_spec on the stack
    Date
    From: Alaa Hleihel <alaa@mellanox.com>

    commit c08cfb2d8d78bfe81b37cc6ba84f0875bddd0d5c upstream.

    Initialize ib_spec on the stack before using it, otherwise we will have
    garbage values that will break creating default rules with invalid parsing
    error.

    Fixes: a37a1a428431 ("IB/mlx4: Add mechanism to support flow steering over IB links")
    Link: https://lore.kernel.org/r/20200413132235.930642-1-leon@kernel.org
    Signed-off-by: Alaa Hleihel <alaa@mellanox.com>
    Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/hw/mlx4/main.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/infiniband/hw/mlx4/main.c
    +++ b/drivers/infiniband/hw/mlx4/main.c
    @@ -1614,8 +1614,9 @@ static int __mlx4_ib_create_default_rule
    int i;

    for (i = 0; i < ARRAY_SIZE(pdefault_rules->rules_create_list); i++) {
    + union ib_flow_spec ib_spec = {};
    int ret;
    - union ib_flow_spec ib_spec;
    +
    switch (pdefault_rules->rules_create_list[i]) {
    case 0:
    /* no rule */

    \
     
     \ /
      Last update: 2020-05-04 20:01    [W:2.374 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site