Messages in this thread | | | Date | Mon, 4 May 2020 10:03:00 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH v3] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac() |
| |
On Sun, 3 May 2020 15:49:32 -0500 wu000273@umn.edu wrote: > From: Qiushi Wu <wu000273@umn.edu> > > In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open. > But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released, > which can lead to a memory leak bug. Thus add a call of the function > “nfp_nsp_close” for the completion of the exception handling. > > Fixes: f6e71efdf9fb1 ("nfp: abm: look up MAC addresses via management FW") > Signed-off-by: Qiushi Wu <wu000273@umn.edu>
This just makes the code longer. v1 was perfectly fine, thanks for the fix.
| |