lkml.org 
[lkml]   [2020]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: enetc: fix an issue about leak system resources
From
Date
> the related system resources were not released when enetc_hw_alloc()
> return error in the enetc_pci_mdio_probe(), add iounmap() for error
> handling label "err_hw_alloc" to fix it.

How do you think about a wording variant like the following?

Subject:
[PATCH v2] net: enetc: Complete exception handling in enetc_pci_mdio_probe()

Change description:
A call of the function “enetc_hw_alloc” can fail here.
The corresponding system resources were not released then.
Thus move a call of the function “iounmap” behind
the label “err_hw_alloc”.


Would you like to reduce the labels for this function implementation instead?

Regards,
Markus

\
 
 \ /
  Last update: 2020-05-04 16:12    [W:0.025 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site