lkml.org 
[lkml]   [2020]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac()
From
Date
> … Thus add a call of the function
> “nfp_nsp_close” for the completion of the exception handling.

I suggest to mention also the addition of a jump target because of
a Linux coding style concern.



> +++ b/drivers/net/ethernet/netronome/nfp/abm/main.c

> @@ -300,12 +297,16 @@ nfp_abm_vnic_set_mac(struct nfp_pf *pf, struct nfp_abm *abm, struct nfp_net *nn,

> +generate_random_address:
> + eth_hw_addr_random(nn->dp.netdev);
> + return;
> }


I recommend to apply the check “RETURN_VOID” once more.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=0e698dfa282211e414076f9dc7e83c1c288314fd#n4866

Regards,
Markus

\
 
 \ /
  Last update: 2020-05-04 08:02    [W:0.133 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site