Messages in this thread | | | Date | Mon, 4 May 2020 13:43:50 +0100 | From | Mark Rutland <> | Subject | Re: [PATCH] arm64/cpuinfo: Move device_initcall() near cpuinfo_regs_init() |
| |
On Mon, May 04, 2020 at 05:59:37PM +0530, Anshuman Khandual wrote: > This moves device_initcall() near cpuinfo_regs_init() making the calling > sequence clear. Besides it is a standard practice to have device_initcall() > (any __initcall for that matter) just after the function it actually calls. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Suzuki Poulose <suzuki.poulose@arm.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> --- > Based on 5.7-rc4 > > arch/arm64/kernel/cpuinfo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c > index 86136075ae41..a515d8f3639e 100644 > --- a/arch/arm64/kernel/cpuinfo.c > +++ b/arch/arm64/kernel/cpuinfo.c > @@ -311,6 +311,8 @@ static int __init cpuinfo_regs_init(void) > } > return 0; > } > +device_initcall(cpuinfo_regs_init); > + > static void cpuinfo_detect_icache_policy(struct cpuinfo_arm64 *info) > { > unsigned int cpu = smp_processor_id(); > @@ -403,5 +405,3 @@ void __init cpuinfo_store_boot_cpu(void) > boot_cpu_data = *info; > init_cpu_features(&boot_cpu_data); > } > - > -device_initcall(cpuinfo_regs_init); > -- > 2.20.1 >
| |