Messages in this thread | | | Date | Mon, 04 May 2020 20:34:02 +0930 | From | "Andrew Jeffery" <> | Subject | Re: [PATCH v5] ARM: DTS: Aspeed: Add YADRO Nicole BMC |
| |
On Mon, 27 Apr 2020, at 20:41, Joel Stanley wrote: > On Fri, 24 Apr 2020 at 13:53, Alexander Filippov <a.filippov@yadro.com> wrote: > > > > Nicole is an OpenPower machine with an Aspeed 2500 BMC SoC manufactured > > by YADRO. > > > > Signed-off-by: Alexander Filippov <a.filippov@yadro.com> > > This looks good to me. > > Andrew, do you have any comments before I merge?
Not other than muxing all the ADC lines to enable just one seems a bit strange, but Alexander mentioned previously that the rest were simply grounded so it's not going to cause any problems in practice.
Andrew
| |